-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to support API prefixed Model example I/O files #1493
base: master
Are you sure you want to change the base?
Conversation
Thanks @Malikbadmus I think we can safely take the plunge into renaming everything and keeping just the new version. |
Noted, @DhanshreeA. I will proceed with renaming the example files in the model repositories |
If you look into the issue of the example_standard files generated by the runner maybe it is a good time to close/merge this PR which is related to the input examples as well. Just suggesting! Let me know if it does not make sense |
Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed
Description
This PR refactors Ersilia to support the handling of model example input and output files, ensuring backward compatibility with the previously used input.csv and output.csv filenames. It introduces changes to accommodate the new file naming convention with a run_ prefix (e.g., run_input.csv, run_output.csv), while still maintaining support for models that use the old naming convention.
This is part of the ongoing effort to support multiple APIs within Ersilia models and provide flexibility for future extensions.
Changes to be made
run_input.csv
andrun_output.csv
alongside the existinginput.csv
andoutput.csv
.PREDEFINED_EXAMPLE_FILES
indefault.py
to include the new file naming conventions.run_input.csv
andrun_output.csv
during the build process, ensuring they are available in the container for model inference._write_api_schema
to handle the new example files(run_input.csv and run_output.csv)
in addition to the old files.input.csv
andoutput.csv
files continue to function without modification, while working towards renaming the files to include run prefix in model repositories.Status
Ongoing
To do
Related to #74